This repository has been archived by the owner on Jun 7, 2024. It is now read-only.
use smaller Docker networks #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as we can't ask docker to pick a random /24 subnet for us we randomly choose a /24 subnet from the address space Docker would normally use
justahero
reviewed
May 13, 2024
|
|
||
| #[test] | ||
| fn stress() { | ||
| let mut networks = vec![]; |
There was a problem hiding this comment.
This test fails on my Macbook. There are 5 other Docker networks present unrelated to this project when I run this test.
There was a problem hiding this comment.
are those networks created by default in a fresh macOS installation? what are their subnet masks? perhaps we should docker network inspect the output of docker network ls and use the subnet masks not shown there.
There was a problem hiding this comment.
This is the collection of information on my Macbook.
$ docker network ls
NETWORK ID NAME DRIVER SCOPE
71ce00f0ea3c bridge bridge local
4ddc8f3c484c customer-portal_cp_net bridge local
eb3ec8e5c769 download-server_criticalup_net bridge local
05a125eec965 host host local
e40dd388a572 none null localSubnet masks for the first three entries are:
172.17.0.0/16
172.20.0.0/16
172.21.0.0/16
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as we can't ask docker to pick a random /24 subnet for us we randomly choose a /24 subnet from the address space Docker would normally use
closes #17